Skip to content

Subtitle formats#7

Draft
winscripter wants to merge 1 commit intojimm98y:mainfrom
winscripter:subtitles
Draft

Subtitle formats#7
winscripter wants to merge 1 commit intojimm98y:mainfrom
winscripter:subtitles

Conversation

@winscripter
Copy link
Copy Markdown
Contributor

I'd like to add subtitle reading/writing support to SharpMP4.

I've began by creating a blank library named SharpSubtitles, to align with naming conventions of other projects. Let me know if this needs to be renamed.

In order to begin adding subtitle formats, I'd need to ask a few questions.

  • Which subtitle formats would you like me to implement? I've heard MP4s typically reference SRT, VTT or SSA formats, but if you'd like a broader subtitle support, e.g. TTML, I can implement those too.
  • Would you like async support? For instance, await subtitle.WriteAsync()
  • Should I group formats into namespaces? For instance, SRT subtitles live under the SharpSubtitles.Srt namespace.

I would like to note that I'm not really experienced with MP4 boxes so I'm not really sure how would I add the subtitle track, but I will implement the formats themselves which acts as a nice infrastructure.

I've made sure to start with subtitles first since these are generally easier to implement and debug for me.

@winscripter
Copy link
Copy Markdown
Contributor Author

@jimm98y Apologies for the delayed response, should I implement the specified tracks/sample entries or should I also write implementations for parsing these subtitles? The names WebVTTSampleEntry and XMLSubtitleSampleEntry and TextTrackImpl suggest WebVTT and TTML functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants