fix: harden lifecycle checks and reduce redundant work - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed files replaced by same-content symlinks are now preserved as user replacements during install, status, and uninstall. Completion security audits run on first interactive use and rebuild both the dump and bytecode before retaining a daily clean-audit marker. Equal file counts cannot reuse unaudited registrations, failed cache generation leaves auditing enabled, and changed marker paths remain untouched. Status also checks developer configuration retained after switching to minimal.
Validation:
bash scripts/check.shpassed locally on macOS with Bash 3.2: 21 suites, 345 passing tests, no failures or skips. Focused regression tests cover user-path preservation, cache invalidation, inventory reuse, binary/CRLF/no-final-newline preservation, and injected copy failures.Isolated macOS median measurements: 1 MiB block suffix removal improved from 1.54 s to 42 ms; six mise tool detections improved from 70 ms to 17 ms. Cached base shell startup remains about 13 ms. Cache identity uses filesystem metadata rather than hashing executables at startup; its same-second in-place-edit limitation is documented in
docs/PERFORMANCE.md.