Skip to content

A couple algorithms#2

Open
nkkarpov wants to merge 5 commits intojiecchen:masterfrom
nkkarpov:master
Open

A couple algorithms#2
nkkarpov wants to merge 5 commits intojiecchen:masterfrom
nkkarpov:master

Conversation

@nkkarpov
Copy link
Copy Markdown

Misra-Gries and SpaceSaving

@nkkarpov nkkarpov closed this May 30, 2019
@nkkarpov nkkarpov reopened this May 30, 2019
//
// Created by Nikolai Karpov on 2019-02-24.
//
#include "streamingcc_include/MisraGries.h"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nikolai,
can you keep the naming consistent (i.e., use lowercase to name the files). Thanks!

src/streamingcc Outdated
#include "streamingcc_include/count_min.h"
#include "streamingcc_include/sampling.h"
#include "streamingcc_include/MisraGries.h"
#include "streamingcc_include/SpaceSaving.h"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, naming issues.

@nkkarpov
Copy link
Copy Markdown
Author

nkkarpov commented Jun 18, 2019

I renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants