Skip to content

Albert/backend - #1

Open
Abert223 wants to merge 139 commits into
masterfrom
albert/backend
Open

Albert/backend#1
Abert223 wants to merge 139 commits into
masterfrom
albert/backend

Conversation

@Abert223

Copy link
Copy Markdown
Collaborator

Parameterized the logic within the ldst unit files and testbenches. Test bench ran back with all test passing with original parameters, have not tried new parameters yet.

@jiayi-wang98 jiayi-wang98 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort! Please see inline comments for changes. And for next PR, make sure that when you run the testbench, there's no warning when compiling RTLs and all testcases pass.

Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/tb/cgra_core/ldst_unit/temporal_coalescing_unit/filelist.f Outdated
@Abert223
Abert223 requested a review from patrickh567 November 28, 2025 22:48
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv
Comment thread dice_new/tb/cgra_core/ldst_unit/temporal_coalescing_unit/tb_tcu.sv Outdated

@patrickh567 patrickh567 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address issues mentioned in comments before merging

@jiayi-wang98 jiayi-wang98 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please see inline comments of BITMAP_WIDTH.

Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/memory_cmd_coalesce_buffer.sv Outdated

@jiayi-wang98 jiayi-wang98 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with some minor issues.

Please try to test in testbench with different parameters (such as 64/32-bit address width and 64/32-bit data width and other parameters) so that we can tell if we missed any place to be changed from the VCS warning "connection width mismatch".

Comment thread dice_new/rtl/cgra_core/ldst_unit/temporal_coalescing_unit.sv Outdated
Comment thread dice_new/rtl/cgra_core/ldst_unit/temporal_coalescing_unit.sv Outdated
enorman24 and others added 30 commits February 21, 2026 16:40
block commit updated / ldst takes 32 bits now
…ntiation of the memory/cache into tb, will wire tmcu later in main file
Scoreboard refactor fixed. back-to-back cta dispatch possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants