Upgrade core deps and modernize lint stack - #402
Merged
Merged
Conversation
Brings the toolchain up to current versions to unblock @actions/github v9 and @octokit/rest v22 (both now ESM-only). - TypeScript 4.3 -> 5.9; tsconfig switched to ES2022 / module esnext / moduleResolution bundler with skipLibCheck for octokit interop. - Jest 26 -> 30, ts-jest 26 -> 29, nock 13 -> 14 (needed for fetch interception now that @octokit/request uses native fetch). Jest config moved to ESM mode (useESM, extensionsToTreatAsEsm, --experimental-vm-modules). - Replaced @typescript-eslint/parser v4 + eslint v7 + eslint-plugin-github v4 with eslint 9 + typescript-eslint 8; migrated config from .eslintrc.json to flat eslint.config.js. Drops the github preset (transitive bloat for rules we don't use) and the ts-eslint stylistic rules now owned by @Stylistic. Source adjustments for the new APIs: - octokit.repos.X -> octokit.rest.repos.X - guarded response.data.files (now optional) and coerced DiffEntry.sha (now string | null) - narrowed unknown error before reading .message - replaced ternary-as-statement and removed unnecessary type assertion that the new lint rules flagged Tests updated for ESM imports and Jest 30 (toThrowError -> toThrow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the toolchain up to current versions to unblock @actions/github
v9 and @octokit/rest v22 (both now ESM-only).
moduleResolution bundler with skipLibCheck for octokit interop.
interception now that @octokit/request uses native fetch). Jest
config moved to ESM mode (useESM, extensionsToTreatAsEsm,
--experimental-vm-modules).
eslint-plugin-github v4 with eslint 9 + typescript-eslint 8;
migrated config from .eslintrc.json to flat eslint.config.js. Drops
the github preset (transitive bloat for rules we don't use) and the
ts-eslint stylistic rules now owned by @Stylistic.
Source adjustments for the new APIs:
DiffEntry.sha (now string | null)
assertion that the new lint rules flagged
Tests updated for ESM imports and Jest 30 (toThrowError -> toThrow).