Fix screen and cursor flickering#201
Open
stianhoiland wants to merge 1 commit intojhawthorn:masterfrom
Open
Conversation
Terminal redrawing should never clear before drawing - Instead set cursor to starting point, (over)write, then erase-from-cursor-to-end-of-line after outputting each line, and erase-to-end-of-screen after last output Also hide cursor while redrawing and show again after
phillipwood
reviewed
Feb 22, 2026
| for (size_t i = 0; i < state->cursor; i++) | ||
| fputc(state->search[i], tty->fout); | ||
| tty_flush(tty); | ||
| tty_showcursor(tty); |
There was a problem hiding this comment.
This leaves the cursor hidden for me, it needs to be called before tty_flush() to have an effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal redrawing should never clear before drawing
Also hide cursor while redrawing and show again after