Bitbucket support#1
Open
jfcolomer wants to merge 17 commits into
Open
Conversation
marcelovani
reviewed
Mar 13, 2019
| * Holds the controller name. | ||
| * | ||
| * @var string $name. | ||
| * @var string $name . |
Contributor
There was a problem hiding this comment.
What is the space about
Owner
Author
There was a problem hiding this comment.
I've removed them according to the drupal coding standards.
Contributor
|
I think its better if you do not commit composer.lock |
marcelovani
reviewed
Mar 15, 2019
| } | ||
| else { | ||
| $this->repoController->setAuthToken($authToken); | ||
| // @todo: define $appPassword. |
Contributor
There was a problem hiding this comment.
All of these changes to add user/pass need to be in the hook_form_alter of the submodule
marcelovani
reviewed
Mar 15, 2019
| $form['repo']['repo_controller'] = [ | ||
| '#type' => 'select', | ||
| '#title' => $this->t('Repo provier'), | ||
| '#title' => $this->t('Repo provider'), |
marcelovani
reviewed
Mar 15, 2019
| */ | ||
| public function setAuthToken($authToken); | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
This doesnt have to be on this interface
marcelovani
reviewed
Mar 15, 2019
|
|
||
| /** | ||
| * Creates the authentication using the token. | ||
| * Creates the authentication using the token/password. |
Contributor
There was a problem hiding this comment.
user/password is a thing only for bitbucket, so no need to be here
marcelovani
reviewed
Mar 15, 2019
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setAppPassword($appPassword) {} |
Contributor
There was a problem hiding this comment.
no password for github
Owner
Author
You're right, I've removed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.