Skip to content

fix(clean): remove library from ALLOWED_DIRS and sandbox-safe rmSync fallback #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jestersimpps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(clean): remove library from ALLOWED_DIRS and sandbox-safe rmSync fallback #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/clean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ const fs = require('fs');
const path = require('path');
const { OBOL_DIR } = require('./config');

const ALLOWED_DIRS = new Set(['personality', 'scripts', 'tests', 'commands', 'apps', 'logs', 'assets', 'library']);
const ALLOWED_DIRS = new Set(['personality', 'scripts', 'tests', 'commands', 'apps', 'logs', 'assets']);
const ALLOWED_ROOT_FILES = new Set([
'config.json',
'secrets.json',
'.evolution-state.json',
'.first-run-done',
'.post-setup-done',
]);
const TEMP_DOTDIRS = new Set(['.typst', '.cache', '.tmp']);
const TEMP_DOTDIRS = new Set(['.typst', '.tmp']);

// Extensions that belong in scripts/
const SCRIPT_EXTS = new Set(['.js', '.ts', '.sh', '.py', '.rb', '.php', '.go', '.rs', '.pl', '.lua']);
Expand Down Expand Up @@ -102,8 +102,16 @@ function applyIssues(baseDir, issues) {
try {
fs.rmSync(src, { recursive: true, force: true });
applied.push({ path: item.name + '/', action: 'deleted (empty dir)' });
} catch (e) {
errors.push(`Failed to delete ${item.name}/: ${e.message}`);
} catch {
// rmSync may be blocked in sandboxed environments — fall back to moving
try {
const fallbackName = item.name.replace(/^\./, '_dot_');
fs.mkdirSync(path.join(baseDir, 'apps'), { recursive: true });
fs.renameSync(src, path.join(baseDir, 'apps', fallbackName));
applied.push({ path: item.name + '/', action: `moved → apps/${fallbackName}/ (delete blocked)` });
} catch (e2) {
errors.push(`Failed to clean ${item.name}/: ${e2.message}`);
}
}
} else {
const dest = path.join(baseDir, 'apps', item.name);
Expand Down