Repository navigation
Rename B to trials - #45
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jerome-white
force-pushed
the
issue-39-trials
branch
from
October 21, 2026 19:45
5480b46 to
51afa39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39. Part of #38.
What this does
Bis renamedtrials(formerlyB; Carterette and Sakai write it as B), everywhere:randomized_tukey_hsd(...; trials, systems). The error is nowtrials must be positive, got .... Internally the variable istrialstoo; the local that held "the number of trials at least as large as the difference" is renamedexceedingso the two do not clash. Docstring updated.--trials N,-n Nand--B Nare the same option (dest_name = "trials");--helpshows-n, --trials, --B TRIALS; the missing-option error now readsrequired option --trials was not provided. The settings message printstrials(it used to printB).benchmark/randomized_tukey.jlprints atrialscolumn header. The tables already recorded inbenchmark/README.mdkeep theirBheader, with a note at the top sayingBthere istrials.Decisions
0.1.0-DEVand nothing depends on it, soB=simply no longer exists (calling with it is aMethodErrorfor the missingtrials).--Bworks without a warning. Say if you want it to warn, and when it should go.NEWS.mdstarted here. The README line fortrialssays it was calledBbefore ("calledBin the literature and in earlier versions of this package") and the benchmark README notes the old header. ANEWS.mdis the question left open on Rename B to trials (library keyword and CLI option) #39 and Neutral vocabulary: blocks and treatments in docs and output #42.Bintest/reference/text that describes Sakai's tool (his recommendation of B between 1000 and 5000) andBas a system name in the fixtures.Verification
] test: 111 pass + 1 deliberately broken at 1 and 4 threads.benchmark/snapshot.jloutput is byte-identical to before the rename.--trials 500,-n 500and--B 500give identical output with--seed 1, identical to the old--B 500 --seed 1output; omitting it gives the error above.🤖 Generated with Claude Code