Skip to content

chore: align Node.js targets#527

Merged
jens-maus merged 1 commit into
jens-maus:masterfrom
KristjanESPERANTO:node
Jul 18, 2026
Merged

chore: align Node.js targets#527
jens-maus merged 1 commit into
jens-maus:masterfrom
KristjanESPERANTO:node

Conversation

@KristjanESPERANTO

@KristjanESPERANTO KristjanESPERANTO commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation

    • Updated the fromURL example to clarify its use of the native fetch API and supported options.
  • Chores

    • Updated the CommonJS build target to Node.js 22.
    • Added a CI note documenting required version alignment.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5b15cd8-29ab-4300-9473-26347299c93c

📥 Commits

Reviewing files that changed from the base of the PR and between 7a17053 and 98ccb8a.

📒 Files selected for processing (3)
  • .github/workflows/nodejs.yml
  • README.md
  • build/build-cjs.js

📝 Walkthrough

Walkthrough

The CommonJS build target changes from Node.js 20 to Node.js 22. CI documentation now notes synchronization with related settings, and the README updates the fromURL runtime description.

Changes

Runtime target and documentation alignment

Layer / File(s) Summary
Node.js 22 build target
build/build-cjs.js, .github/workflows/nodejs.yml
The CommonJS esbuild target is updated to node22, and the CI matrix includes a comment about keeping related Node settings synchronized.
fromURL runtime documentation
README.md
The autodetect documentation removes the explicit Node.js 20 or global fetch requirement while retaining the native fetch and options-forwarding description.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating Node.js targets across build, docs, and workflow notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jens-maus
jens-maus merged commit e89a53a into jens-maus:master Jul 18, 2026
14 checks passed
@KristjanESPERANTO
KristjanESPERANTO deleted the node branch July 18, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants