Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>analysis-pom</artifactId>
<version>10.11.0</version>
<version>10.14.0</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -291,8 +291,8 @@
<item>
<ignore>true</ignore>
<regex>true</regex>
<code>java.class.nonPublicPartOfAPI</code>
<classQualifiedName>(one.util.streamex.Joining.*|j2html.utils.JSMin.*)</classQualifiedName>
<code>java.*</code>
<classQualifiedName>(one.util.*|j2html.utils.JSMin.*)</classQualifiedName>
<justification>These libraries are part of the API</justification>
</item>
<item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
*/
@SuppressFBWarnings("IS2_INCONSISTENT_SYNC")
public class GlobalConfigurationItem extends GlobalConfiguration {
@SuppressWarnings("PMD.DoNotUseThreads")
private transient Runnable actualSave;
@SuppressWarnings("PMD.DoNotUseThreads")
private transient Runnable actualLoad;

/**
Expand Down
15 changes: 7 additions & 8 deletions src/main/java/io/jenkins/plugins/util/JenkinsFacade.java
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
package io.jenkins.plugins.util;

import java.io.Serial;
import java.io.Serializable;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;

import org.apache.commons.lang3.StringUtils;
import org.jenkins.ui.symbol.Symbol;
import org.jenkins.ui.symbol.SymbolRequest;
import org.springframework.security.access.AccessDeniedException;

import edu.umd.cs.findbugs.annotations.CheckForNull;

import java.io.Serial;
import java.io.Serializable;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;

import org.kohsuke.stapler.Stapler;
import org.kohsuke.stapler.StaplerRequest2;
import hudson.DescriptorExtensionList;
Expand All @@ -36,7 +36,6 @@
*
* @author Ullrich Hafner
*/
@SuppressWarnings("PMD.ExcessiveImports")
public class JenkinsFacade implements Serializable {
@Serial
private static final long serialVersionUID = 1904631270145841113L;
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/io/jenkins/plugins/util/LogHandler.java
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
package io.jenkins.plugins.util;

import java.util.List;

import com.google.errorprone.annotations.FormatMethod;

import edu.hm.hafner.util.FilteredLog;

import java.util.List;

import hudson.model.TaskListener;

/**
* Handles logging of issues log and error messages to a {@link TaskListener} instance.
*
* @author Ullrich Hafner
*/
@SuppressWarnings("PMD.LoggerIsNotStaticFinal")
public class LogHandler {
private final PluginLogger errorLogger;
private final PluginLogger infoLogger;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package io.jenkins.plugins.util;

import java.util.Objects;

import org.apache.commons.lang3.StringUtils;
import org.apache.commons.text.StringEscapeUtils;
import org.assertj.core.api.AbstractAssert;

import java.util.Objects;

import hudson.util.FormValidation;
import hudson.util.FormValidation.Kind;

Expand All @@ -14,7 +14,7 @@
*
* @author Ullrich Hafner
*/
@SuppressWarnings({"NonBooleanMethodNameMayNotStartWithQuestion", "PMD.LinguisticNaming"})
@SuppressWarnings("NonBooleanMethodNameMayNotStartWithQuestion")
public class FormValidationAssert extends AbstractAssert<FormValidationAssert, FormValidation> {
private static final String EXPECTED_BUT_WAS_MESSAGE = "%nExpecting %s of:%n <%s>%nto be:%n <%s>%nbut was:%n <%s>.";

Expand Down
26 changes: 13 additions & 13 deletions src/test/java/io/jenkins/plugins/util/IntegrationTest.java
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
package io.jenkins.plugins.util;

import java.io.BufferedReader;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.IOException;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
import java.util.Arrays;
import java.util.Collections;
import java.util.Objects;
import java.util.function.Function;

import org.junit.jupiter.api.Tag;
import org.jvnet.hudson.test.JenkinsRule;
import org.jvnet.hudson.test.JenkinsRule.JSONWebResponse;
Expand All @@ -28,6 +16,18 @@
import edu.hm.hafner.util.PathUtil;
import edu.hm.hafner.util.ResourceTest;

import java.io.BufferedReader;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.IOException;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.nio.file.Path;
import java.util.Arrays;
import java.util.Collections;
import java.util.Objects;
import java.util.function.Function;

import org.jenkinsci.plugins.workflow.cps.CpsFlowDefinition;
import org.jenkinsci.plugins.workflow.flow.FlowDefinition;
import org.jenkinsci.plugins.workflow.job.WorkflowJob;
Expand Down Expand Up @@ -62,7 +62,7 @@
* @author Ullrich Hafner
*/
@Tag("IntegrationTest")
@SuppressWarnings({"ClassDataAbstractionCoupling", "ClassFanOutComplexity", "SameParameterValue", "PMD.SystemPrintln", "PMD.GodClass", "PMD.ExcessiveClassLength", "PMD.ExcessiveImports", "PMD.CouplingBetweenObjects", "PMD.CyclomaticComplexity", "unused"})
@SuppressWarnings({"ClassDataAbstractionCoupling", "ClassFanOutComplexity", "SameParameterValue", "PMD.SystemPrintln", "PMD.CouplingBetweenObjects", "PMD.CyclomaticComplexity", "unused"})
public abstract class IntegrationTest extends ResourceTest {
private static final Charset UTF_8 = StandardCharsets.UTF_8;

Expand Down
Loading