Migrate from Commons Lang to native Java Platform functionality - #33
Open
timja wants to merge 1 commit into
Open
Migrate from Commons Lang to native Java Platform functionality#33timja wants to merge 1 commit into
timja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to use a third-party library when this functionality is available in the Java Platform.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
All usage is in Groovy sources. Six files:
StringUtils.isEmpty/isNotEmpty/isBlank/isNotBlank→ explicit null-and-empty checks;StringUtils.defaultIfEmpty(x, "")→ Groovy's?:elvis operator.ExceptionUtils.getStackTrace(e)→Functions.printThrowable(e), Jenkins core's own renderer.RandomStringUtils.random(10, true, true), which generates the Mac user account password, is nowa local helper over
SecureRandom. Commons Lang 2 backed that call with a plainjava.util.Random,and I did not want to hand-write a weaker generator for a credential. Same length and alphabet as
before; happy to drop it back if you would rather keep it identical.
Testing done
mvn -B -ntp clean verifypasses locally on Java 11 / macOS. Java 21 does not work:maven-license-pluginfails, on unmodifiedmastertoo.The
ban-commons-lang-2enforcer rule was left disabled because it needs parent POM6.2116.v7501b_67dc517or newer; bumping the parent from4.xwas out of scope here.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact
@parameter.