Support for copying file from Jenkins host to agents - #27
Open
jonkipu wants to merge 1 commit into
Open
Conversation
Member
|
Hi @jonkipu, the code looks clean thank you. Please add somes tests, especially for the new method uploadHostFile. I will try your feature and let you know. |
Author
|
Thanks I will try to add some tests, also I want to fix a possible security issue with the path resolving to make sure you can't "escape" the home folder. Will update you when I'm done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a config option for the host to allow selecting Jenkins File Credentials items to be uploaded to a path relative to the agent's User home folder, this was useful to me in some cases where I was using tools requiring specific config files including password / tokens etc (.npmrc, .aws config, ssh config)
Pretty similar to #15 but I needed it to be more generic
Unsure to write tests for such a feature since I'm pretty new to Jenkins plugins, would love some guidance in this area