Make googleStorageBuildLogUpload work in post#175
Open
cha5on wants to merge 2 commits intojenkinsci:developfrom
Open
Make googleStorageBuildLogUpload work in post#175cha5on wants to merge 2 commits intojenkinsci:developfrom
cha5on wants to merge 2 commits intojenkinsci:developfrom
Conversation
It is expected that steps in a pipeline post section always run if specified with an "always" condition. Change 51fee77 fixed this behavior for the googleStorageUpload step, and this change similarly fixes googleStorageBuildLogUpload. Add a unit test to confirm that this works as intended. Fixes jenkinsci#89.
|
I was disappointed to see that the log of failed builds was not uploaded, even though I would like to see it later. |
Contributor
Author
|
@alecharp or @donmccasland: would one of you be open to reviewing this or to assigning another reviewer? |
Contributor
Author
|
ping |
Contributor
Author
|
hello! please let me know if there are any additional changes needed to get this landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is expected that steps in a pipeline post section always run if specified with an "always" condition. Change 51fee77 fixed this behavior for the
googleStorageUploadstep, and this change similarly fixesgoogleStorageBuildLogUpload.Add a unit test to confirm that this works as intended.
Fixes #89.