Skip to content

Handle missing sids collections in role constructors - #111

Open
somiljain2006 wants to merge 1 commit into
jenkinsci:masterfrom
somiljain2006:Export-null-issue
Open

Handle missing sids collections in role constructors#111
somiljain2006 wants to merge 1 commit into
jenkinsci:masterfrom
somiljain2006:Export-null-issue

Conversation

@somiljain2006

@somiljain2006 somiljain2006 commented May 31, 2026

Copy link
Copy Markdown

Fixes jenkinsci/configuration-as-code-plugin#2811

Normalize null collection values to empty sets in role constructors to prevent failures when configuration fields are omitted.

Testing done

Add regression tests covering JCasC configurations without sids and role initialization with missing collection values.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@somiljain2006
somiljain2006 requested a review from a team as a code owner May 31, 2026 07:06
@somiljain2006

somiljain2006 commented May 31, 2026

Copy link
Copy Markdown
Author

@basil @oleg-nenashev @AbhyudayaSharma Can you review this pr?

@oleg-nenashev

Copy link
Copy Markdown
Member

The change looks about right. I haven't touched the code of this plugin for a while though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export does not produce empty element for empty inputs

2 participants