Use Jenkins.checkGoodName for credential ID validation#1029
Open
Aadigarg111 wants to merge 1 commit intojenkinsci:masterfrom
Open
Use Jenkins.checkGoodName for credential ID validation#1029Aadigarg111 wants to merge 1 commit intojenkinsci:masterfrom
Aadigarg111 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
timja
requested changes
Mar 23, 2026
Member
timja
left a comment
timja
left a comment
There was a problem hiding this comment.
Unable to run Maven tests in this environment (mvn is not installed).
We do not accept pull requests that have not been tested.
If you want to continue with this you will need to set it up, see https://github.com/jenkinsci/.github/blob/master/CONTRIBUTING.md#run-locally
| if (!value.matches("[a-zA-Z0-9_.-]+")) { // anything else considered kosher? | ||
| return FormValidation.error("Unacceptable characters"); | ||
| try { | ||
| Jenkins.checkGoodName(value); |
Member
There was a problem hiding this comment.
other than changing the allowed character set this does nothing its the same result as before.
When saving the credentials it needs to call checkGoodName not just when validating it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doCheckIdwithJenkins.checkGoodNameTesting
mvnis not installed).