Skip to content

Refactor CitationSearch component and citations.js #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cindywu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor CitationSearch component and citations.js #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions app/javascript/components/editor-config/citations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { saRequest } from '../../utils/saRequest'
import parse from 'html-react-parser'
import classnames from 'classnames'
import { store } from '../../store'
import {v4 as uuidv4} from 'uuid'

export const citationPluginKey = new PluginKey('citations')

Expand Down Expand Up @@ -102,7 +103,7 @@ export const addCitation = function (state, dispatch, view) {
var { currentUser, currentPost } = store.getState()

const newCitation = new Citation(
randomID(),
uuidv4(),
payload.value,
highlightedText,
payload.url
Expand Down Expand Up @@ -150,7 +151,7 @@ export const addCitation = function (state, dispatch, view) {
})
p.then((result) => {
const newCitation = new Citation(
randomID(),
uuidv4(),
payload.value,
highlightedText,
result.body.post.slug
Expand Down Expand Up @@ -244,10 +245,6 @@ export const citationPlugin = new Plugin({
},
})

function randomID() {
return Math.floor(Math.random() * 0xffffffff)
}

export const citationUI = function (transaction) {
return new Plugin({
props: {
Expand Down