console warnings and React 19

[AnnMarieW]

Hi @jeffgallini

This looks like a really nice component. There’s a lot here already, especially for a first release.

A couple questions and notes from trying it out:

React dependency

It looks like mantine-datatable v8 requires react 19, but the install step overrides this using

npm install --legacy-peer-deps

so it installs with React 18 (which Dash requires).

Since Mantine v8 supports both React 18 and 19, do you know if mantine-datatable actually needs React 19? Or is that just an overly strict peer dependency?

Console warnings

When I run the quick start app I see two warnings:

Warning: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

The defaultProps one is easy to fix by switching to default params. I can do a PR for that if you like. I haven’t dug into the ref warning much.

[jeffgallini]

When I was putting together the code, I wasn't looking too deeply at the console and dependencies, mostly just working on stuff until it appears.

That would be great if you want to make a PR! I'll look into the dependencies to see what impact, if any, there would be in making it React 18 vs 19

[AnnMarieW]

Just to be clear on the dependencies - Dash does not support React 19 yet, so you are doing the right thing requiring React 18 when building this component. The question is whether this breaks anything in react-datatable which uses React 19.

The warning about the refs might be related to react 19. Have you seen anything odd with things like popovers, modals or edit components?

Just a note for future development - there is a PR in dash to enable setting react 19 in an app. When that's ready I plan to start working on DMC v3 based on Mantine 9 (which requires react 19)

[jeffgallini]

I just worked through the discussion board, there is some functionality that is vaguely referred to required React19, my guess is it is in the functionality that I haven't built out yet since I haven't seen anything non-functional yet.