Conversation
Hash for SeqSlice and Kmer fed `usize`-typed lengths and bitvec's per-bit Hash to the hasher, producing different digests on 32- vs. 64-bit targets. Replace both impls with an explicit u64 LE length prefix and a `hash_bits` helper that extracts whole bytes via `BitField::load_le::<u8>`, sidestepping bitvec's Hash and the usize storage width. Truncate Kmer's backing bitarray to K * A::BITS so storage padding can't leak into the digest. Tests use a RecordingHasher to capture the byte stream and assert contract-level invariants (cross-route equivalence between Seq / &SeqSlice / Kmer, structural length, padding-independence across storage widths) over a curated set of codecs and lengths.
fix: platform-stable Hash for Seq, SeqSlice, and Kmer (#15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-time coming TLC release