Repository navigation
chore(ci): lint workflows with jactionlint - #15
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesLint tool configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The lint tool configuration is consistent, and no current workflow files are present. No actionable merge-blocking risk is shown. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add a CI workflow running hk check --all, commit a mise.lock covering all tools, and clear existing lua-language-server warnings so the job passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Summary
Lint GitHub Actions workflows with jactionlint, a maintained actionlint fork, as an hk step. It runs locally and in pre-commit and catches bad inputs, expression type errors, script injection and bad runner labels.
This replaces the existing
actionlintstep inhk.pkland swapsactionlintforjactionlintinmise.toml. The hk version is unchanged, and the step is a plain command becauseBuiltins.jactionlintis not in a released hk yet.Findings
None in the step itself. The repo had no
.github/workflowsdirectory, so this PR also adds one (below) and the step now lints it.CI and lockfile
.github/workflows/ci.yml, which runsmise x hk -- hk check --allon pull requests and pushes to main so the jactionlint step is exercised in CI. Actions are pinned to full SHAs, checkout does not persist credentials, and permissions arecontents: read.mise.lockcovering all tools inmise.toml(including jactionlint, hk and pkl) for linux, macos and windows.hk check --allalready failed on existinglua-checkwarnings. Parenthesize one expression inhooks/available.luaand disable theundefined-doc-paramanddoc-field-no-classdiagnostics in.luarc.jsonso the new job passes.Verification
mise x jactionlint@1.8.2 hk@latest pkl@latest -- hk check --all --step jactionlintexits 0.on.push, the same command exits 1 with a syntax-check error. I removed the scratch file afterward.🤖 Generated with Claude Code
AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: claude-code_2-1-293_agent.
Note
Low Risk
Tooling and CI configuration only; the Lua change is a one-line error-message fix with no runtime behavior change beyond clearer errors.
Overview
Adds a CI workflow on pull requests and
mainpushes that installs tools viamise-actionand runshk check --all, so the same hk linters run in GitHub as locally.Workflow linting switches from
actionlinttojactionlintinhk.pklandmise.toml, with batched checks on.github/workflows/*.{yml,yaml}. A newmise.lockpins hk, jactionlint, and other dev tool versions.Minor follow-ons:
.luarc.jsondisables extra doc-related diagnostics, andhooks/available.luafixes string concatenation precedence in a GCS fetch error message.Reviewed by Cursor Bugbot for commit 36c14a4. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit