Repository navigation
chore(ci): lint workflows with jactionlint - #244
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe tools configuration adds ChangesTooling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is established for the tool configuration change; normal checks can proceed. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d4b3c61. Configure here.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

https://entire.io/gh/jdx/demand/trails/25
Adds a
jactionlintstep tohk.pklso workflow files are linted locally and in the hk pre-commit hook with jactionlint, a maintained actionlint fork. It catches bad inputs, expression type errors, script injection and unknown runner labels.jactionlintis added tomise.tomltools.mise.lockis committed but did not list jactionlint, so this also locks it (mise lock jactionlint, v1.8.2, all 7 platforms already in the lockfile). CI already runshk check --allin thetestjob, so the new step is exercised there with no workflow change.Existing findings: none. All three workflows pass, so nothing was fixed or ignored.
Verified with
hk check --all --step jactionlint(exit 0), and by adding an unknown key underon:in a workflow, which exited 1 before I reverted it.🤖 Generated with Claude Code
AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: claude-code_2-1-293_agent.
Note
Low Risk
Tooling and workflow lint configuration only; no application or runtime behavior changes.
Overview
Adds jactionlint to the shared
hklinter set so.github/workflows/*.ymland*.yamlare validated onhk check,hk fix, and pre-commit alongside existing Rust linters.The new step is check-only (
jactionlint {{ files }}, read-only, batched). mise now installsjactionlint(latestinmise.toml, pinned to v1.8.2 across platforms inmise.lock).Reviewed by Cursor Bugbot for commit bf62ce0. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
jactionlintto the latest release.