Repository navigation
chore: add hk pre-commit hook - #239
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No reviewable files after applying ignore patterns. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/jdx/demand/trails/20
hk only installs the git hooks a repo's
hk.pkldefines, and this one had nopre-commithook, sohk installset nothing up and lint ran only when invoked by hand.This adds a
pre-commithook (fix = true,stash = "git") that runs the same linters asfix, matching the other jdx projects.The top-level
stepsare now alintersmapping shared by thepre-commit,fixandcheckhooks.AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.
🤖 Generated with Claude Code
Note
Low Risk
Only hk hook configuration changes; no application runtime or security-sensitive code.
Overview
Refactors
hk.pklso git hooks are defined and share one linter set.Cargo fmt/clippy steps move from a top-level
stepsblock into alintersmapping reused by newpre-commit,fix, andcheckhooks.pre-commitruns with auto-fix enabled andstash = "git"sohk installcan register a hook that runs the same linters as manualfix/check, aligned with other jdx projects.Reviewed by Cursor Bugbot for commit 27c535d. Bugbot is set up for automated code reviews on this repo. Configure here.