Skip to content

chore: add hk pre-commit hook - #239

Merged
jdx merged 1 commit into
mainfrom
chore/hk-pre-commit
Oct 3, 2026
Merged

jdx merged 1 commit into
mainfrom
chore/hk-pre-commit

Conversation

@jdx

@jdx jdx commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

https://entire.io/gh/jdx/demand/trails/20

hk only installs the git hooks a repo's hk.pkl defines, and this one had no pre-commit hook, so hk install set nothing up and lint ran only when invoked by hand.

This adds a pre-commit hook (fix = true, stash = "git") that runs the same linters as fix, matching the other jdx projects.

The top-level steps are now a linters mapping shared by the pre-commit, fix and check hooks.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

🤖 Generated with Claude Code


Note

Low Risk
Only hk hook configuration changes; no application runtime or security-sensitive code.

Overview
Refactors hk.pkl so git hooks are defined and share one linter set.

Cargo fmt/clippy steps move from a top-level steps block into a linters mapping reused by new pre-commit, fix, and check hooks. pre-commit runs with auto-fix enabled and stash = "git" so hk install can register a hook that runs the same linters as manual fix/check, aligned with other jdx projects.

Reviewed by Cursor Bugbot for commit 27c535d. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 3, 2026

Copy link
Copy Markdown

No reviewable files after applying ignore patterns.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • hk.pkl is excluded by !**/*.pkl

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 520c7005-0824-41c7-abdc-cc62b5f642a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx merged commit 3996840 into main Oct 3, 2026
10 checks passed
@jdx
jdx deleted the chore/hk-pre-commit branch October 3, 2026 08:41
@jdx jdx mentioned this pull request Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant