feat: support dumping xllm server flags to json file.#1518
Open
XuZhang99 wants to merge 1 commit into
Open
Conversation
XuZhang99
requested review from
Clement-Wang26,
DongheJin,
DragonFive,
JimHsiung,
Kang-Meng,
RobbieLeung,
liujinguang0125,
liutongxuan,
walsonyang,
xiao-yu-chen,
yingxudeng,
yq33victor and
zhang-minchao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a feature to dump the startup configuration to a JSON file, controlled by new global flags enable_dump_config_json and dump_config_json_file. It introduces append_config_json methods across various configuration classes and a centralized dump_startup_config utility. Feedback was provided to optimize the APPEND_JSON_VALUE_IF_NOT_DEFAULT macro by ensuring the value expression is evaluated only once to prevent side effects or redundant function calls.
XuZhang99
force-pushed
the
feat/dump_config
branch
2 times, most recently
from
87fa5df to
f4863c7
Compare
XuZhang99
force-pushed
the
feat/dump_config
branch
from
f4863c7 to
f2d9432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.