bugfix: fix precision issue of TileLang operator chunk_gated_delta_rule_fwd_h.#1510
Merged
yingxudeng merged 1 commit intoMay 22, 2026
Conversation
fengz72
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the chunk_gated_delta_rule_fwd_h kernel for Ascend targets by adding a T.barrier_all() synchronization call before entering the computation scope. This change ensures proper synchronization across threads before the gated delta rule forward pass logic is executed. There are no review comments to address, and I have no further feedback to provide.
yingxudeng
changed the title
yingxudeng
merged commit 82a407d
into
jd-opensource:preview/qwen3.5-qwen3.6
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix precision issue of TileLang operator chunk_gated_delta_rule_fwd_h