feat: support vae parallel for qwen-image-edit-plus.#1499
Open
shan-chen-feng wants to merge 5 commits into
Open
feat: support vae parallel for qwen-image-edit-plus.#1499shan-chen-feng wants to merge 5 commits into
shan-chen-feng wants to merge 5 commits into
Conversation
shan-chen-feng
requested review from
Clement-Wang26,
DongheJin,
DragonFive,
JimHsiung,
Kang-Meng,
RobbieLeung,
XuZhang99,
liujinguang0125,
liutongxuan,
walsonyang,
xiao-yu-chen,
yingxudeng,
yq33victor and
zhang-minchao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces VAE patch parallelism for the DiT model, adding necessary configuration flags, updating the collective communicator to support VAE process groups, and implementing tiled encoding with row-based parallelism in the AutoencoderKLQwenImage model. The review comments identified several critical issues, including a race condition in the RankGenerator initialization, an incorrect row distribution calculation for VAE parallelism, and encapsulation issues in the RankGenerator class. I have kept the comments pointing out these bugs and improvement opportunities while removing comments that were purely explanatory or lacked actionable feedback.
shan-chen-feng
force-pushed
the
qwenimage_vae_parallel
branch
from
b968992 to
ad3bf68
Compare
shan-chen-feng
force-pushed
the
qwenimage_vae_parallel
branch
from
ad3bf68 to
87db6d7
Compare
XuZhang99
reviewed
May 20, 2026
shan-chen-feng
changed the title
shan-chen-feng
force-pushed
the
qwenimage_vae_parallel
branch
from
87db6d7 to
afa809c
Compare
XuZhang99
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.