feat: add rate limit, monitor, multiple images and input validation for dit.#1483
Merged
Conversation
xiao-yu-chen
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DiT pipeline to support multiple input images by replacing the single condition image with a vector of tensors, affecting the API, request handling, and serialization layers. It also introduces a global flag for maximum image area validation and enhances request latency metrics. Feedback identified a critical bug in the rate-limiting implementation where the request counter is checked but not incremented, potentially causing underflow; a suggestion was made to use an atomic try_acquire mechanism instead.
xiao-yu-chen
requested review from
Clement-Wang26,
DragonFive,
Kang-Meng,
liujinguang0125,
yingxudeng and
zhang-minchao
as code owners
XuZhang99
reviewed
May 21, 2026
xiao-yu-chen
force-pushed
the
dit
branch
2 times, most recently
from
b6ca7ae to
d23ed9b
Compare
XuZhang99
approved these changes
May 21, 2026
wly-115
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.