refactor: remove negative condition when choosing decode or prefill#1475
Open
rauletorresc wants to merge 1 commit into
Open
refactor: remove negative condition when choosing decode or prefill#1475rauletorresc wants to merge 1 commit into
rauletorresc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The changes in xllm/core/runtime/speculative_worker_impl.cpp refactor the step function to improve readability by removing the else block and the negation in the conditional check. The logic now explicitly handles the decode case first and returns, falling through to the prefill case otherwise. As there were no review comments provided for this pull request, I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve readability by:
elseblock when returning from inside theifblock.