feat: support text_encoder for flux2#1452
Conversation
wang-shuibin
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds NPU support for Mistral and Mistral3 models, including the necessary decoder layer implementations, weight loaders, and model registration. The reviewer identified critical issues regarding hardcoded absolute file paths and debugging torch::save calls that must be removed before production. Additionally, several violations of the repository style guide were noted, including incorrect naming conventions for member variables and constants, the use of non-fixed-width integers, redundant virtual keywords, and the use of relative include paths.
wang-shuibin
force-pushed
the
my-clean-branch
branch
from
8d89997 to
fb3626f
Compare
wang-shuibin
left a comment
wang-shuibin
left a comment
There was a problem hiding this comment.
This PR adapts text_encoder(Mistral3 model) for the Flux2 model, and completes the accuracy verification. Compared with the side of MindIE SD, it has been verified that the precision of the text encoder on the xLLM side reaches 99.99%.
wang-shuibin
requested review from
Clement-Wang26,
DragonFive,
Kang-Meng,
liujinguang0125,
xiao-yu-chen,
yingxudeng and
zhang-minchao
as code owners
wang-shuibin
force-pushed
the
my-clean-branch
branch
from
bdd6f47 to
3bc8fd6
Compare
wang-shuibin
force-pushed
the
my-clean-branch
branch
from
113b63d to
db2e84c
Compare
1 participant
Compared with the side of MindIE SD, it has been verified that the precision of the text encoder on the xLLM side reaches 99.99%.