feat: support the wan22's dit and tp parallel.#1445
Open
ethan686 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the Wan 2.2 DiT model, introducing the transformer architecture and expanding model arguments to support VAE and DiT parameters. It also refactors DiTParallelLinear to include Megatron-style tensor parallelism. Reviewer feedback highlights multiple style guide violations, such as the requirement for explicit constructors, final class markers, fixed-width integers, and specific naming conventions for enums and parameters. Additionally, the reviewer identified a redundant semicolon and noted that structs containing member functions must be converted to classes.
XuZhang99
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
including three changes, dit transformer impl, tp parallel for dit model and all the model args changes for wan2.2. Note: use mindiesd's tensor as dit's input, no tp, 10 transformer layer, the cos similarity is 100% match with mindiesd.