feat: support the /v1/video/generation for wan2.2.#1444
Open
ethan686 wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces video generation support across the xLLM stack, including new RPC endpoints, service implementations, and an FFmpeg-based in-memory video encoder. The core DiT framework was updated to handle video-specific parameters and tensors like last_images and image_embeds. Review feedback highlights a critical bug in frame count logic for 3D tensors and missing serialization logic in the shared memory manager. Additionally, several style guide violations were identified concerning fixed-width integer usage, the 'final' keyword for classes, and inappropriate use of 'auto' for simple types. A typo in the protobuf field 'guidence_scale_2' also needs correction.
XuZhang99
reviewed
May 18, 2026
XuZhang99
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.