Skip to content

feat: support the /v1/video/generation for wan2.2.#1444

Open
ethan686 wants to merge 7 commits into
jd-opensource:mainfrom
ethan686:wan22_video_api
Open

feat: support the /v1/video/generation for wan2.2.#1444
ethan686 wants to merge 7 commits into
jd-opensource:mainfrom
ethan686:wan22_video_api

Conversation

@ethan686
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces video generation support across the xLLM stack, including new RPC endpoints, service implementations, and an FFmpeg-based in-memory video encoder. The core DiT framework was updated to handle video-specific parameters and tensors like last_images and image_embeds. Review feedback highlights a critical bug in frame count logic for 3D tensors and missing serialization logic in the shared memory manager. Additionally, several style guide violations were identified concerning fixed-width integer usage, the 'final' keyword for classes, and inappropriate use of 'auto' for simple types. A typo in the protobuf field 'guidence_scale_2' also needs correction.

Comment thread xllm/core/framework/request/dit_request.cpp Outdated
Comment thread xllm/core/runtime/forward_shared_memory_manager.cpp
Comment thread xllm/api_service/video_generation_service_impl.cpp Outdated
Comment thread xllm/api_service/video_generation_service_impl.h Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Comment thread xllm/core/framework/request/mm_codec.cpp Outdated
Comment thread xllm/proto/video_generation.proto Outdated
Comment thread xllm/api_service/video_generation_service_impl.cpp Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Comment thread xllm/core/framework/request/dit_request_params.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants