bugfix: modify the link/unlink workflow for MIX instances.#47
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains a fix for TimePredictor and refactors the linking/unlinking workflow for MIX instances. The change in time_predictor.cpp correctly fixes an initialization bug. However, the refactoring in instance_mgr.cpp for MIX instances introduces a critical issue by making the instance linking unidirectional. This would leave peer instances unaware of the new MIX instance. I've added comments to restore the necessary bidirectional linking for both the main logic and the error-handling rollback path.
weizhehuang0827
approved these changes
Mar 16, 2026
RobbieLeung
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.