Skip to content

(#1) acortar asignación de divObj #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
falopez10 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(#1) acortar asignación de divObj #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c0cfc
(#1) acortar asignación de divObj
falopez10 Feb 16, 2018
e6c1bc9
(#2) Meta keywords
falopez10 Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
<meta name="author" content="Juan Diego Chaves">
<!--la descripcion-->
<meta name="description" content="Pagina web personal de Juan Diego Chaves Sanguino">
<!--Fabio López: Se sugiere agregar meta keywords-->
<meta name="keywords" content="HTML,CSS,Bootstrap, jQuery,JavaScript">
<!--titulo que se muestra en la pestaña-->
<title>Juan Chaves</title>
<link rel="stylesheet" href="utils/styles/styles.css">
Expand Down
3 changes: 2 additions & 1 deletion js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ function main(){
//para la transiciond de la galeria
var fadeActiveSlidesID = null;
//el elemento que tiene la galeria
var divObj = (document.getElementById(divId) ? document.getElementById(divId) : null);
/*Fabio Lopez: Se remueve comparación innecesaria, pues getEelemntById ya retorna null si no existe el elemento*/
var divObj = document.getElementById(divId);
//arreglo de imagenes de la galeria
var imgs = (divObj.querySelectorAll("img") ? divObj.querySelectorAll("img") : []);
//valor del ancho de la imagen mas ancha
Expand Down