Skip to content

fix: restore roadmap tests and lint cleanup #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diii00000123 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: restore roadmap tests and lint cleanup #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73d947f
Disable bigEyeRoad locally (marked broken) - returns empty list; keep…
n125897958 Mar 16, 2026
f22c50c
Fix roadmap big eye tests
n125897958 Mar 16, 2026
b6979f2
fix(lint): remove roadmap debug logs and enforce LF JS endings
n125897958 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.js text eol=lf
89 changes: 44 additions & 45 deletions src/roadmaps/roadmapGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,12 @@ class RoadmapGenerator {
if (lastItemInResults) {
lastItemInResults.ties = _.cloneDeep(tieStack);
tieStack = [];
if (lastItemInResults.result.outcome !== gameResult.outcome) {
logicalColumnNumber++;
}
}
} else if (lastItem.outcome !== gameResult.outcome) {
// If this item is different from the outcome of
// the last game then we must place it in another column
// lastItem is not tie so we can clear the tieStack
// the last game then we must place it in another
// column
logicalColumnNumber++;
tieStack = [];
} else {
// If this item is the same as the outcome of current game and not a tie, then we must clear the tie stack
tieStack = []
}
}

Expand Down Expand Up @@ -201,54 +194,60 @@ class RoadmapGenerator {
let k = cycleLength;
let outcomes = [];

Object.values(columnDefinitions).forEach((bigRoadColumn) => {
let outcome = 'blue';
let n = bigRoadColumn.logicalColumn;

for (let m = 0; m < bigRoadColumn.logicalColumnDepth; m++) {
let rowMDepth = m + 1;
// Iterate columns in numeric order to ensure stable derived-road output.

if (rowMDepth >= 2) {
let compareColumn = n - k;
Object.keys(columnDefinitions)
.map((kStr) => parseInt(kStr, 10))
.sort((a, b) => a - b)
.forEach((colIndex) => {
let bigRoadColumn = columnDefinitions[colIndex];
let outcome = 'blue';
let n = bigRoadColumn.logicalColumn;

// Step 2.a.1 - No column exists here.
if (compareColumn <= 0)
continue;
for (let m = 0; m < bigRoadColumn.logicalColumnDepth; m++) {
let rowMDepth = m + 1;

// Step 2.a.1
let pColumn = columnDefinitions[compareColumn];
if (!pColumn)
continue;

let p = pColumn.logicalColumnDepth;
if (rowMDepth <= p) {
outcome = 'red';
} else if (rowMDepth == (p + 1)) {
outcome = 'blue';
} else if (rowMDepth > (p + 1)) {
outcome = 'red';
}
if (rowMDepth >= 2) {
let compareColumn = n - k;

outcomes.push(outcome);
} else {
let kDistanceColumn = n - (k + 1);
let leftColumn = n - 1;
// Step 2.a.1 - No column exists here.
if (compareColumn <= 0)
continue;

let kDistanceColumnDefinition = columnDefinitions[kDistanceColumn];
let leftColumnDefinition = columnDefinitions[leftColumn];
// Step 2.a.1
let pColumn = columnDefinitions[compareColumn];
if (!pColumn)
continue;

if (kDistanceColumnDefinition != null &&
leftColumnDefinition != null) {
if (kDistanceColumnDefinition.logicalColumnDepth == leftColumnDefinition.logicalColumnDepth)
let p = pColumn.logicalColumnDepth;
if (rowMDepth <= p) {
outcome = 'red';
else
} else if (rowMDepth == (p + 1)) {
outcome = 'blue';
} else if (rowMDepth > (p + 1)) {
outcome = 'red';
}

outcomes.push(outcome);
} else {
let kDistanceColumn = n - (k + 1);
let leftColumn = n - 1;

let kDistanceColumnDefinition = columnDefinitions[kDistanceColumn];
let leftColumnDefinition = columnDefinitions[leftColumn];

if (kDistanceColumnDefinition != null &&
leftColumnDefinition != null) {
if (kDistanceColumnDefinition.logicalColumnDepth == leftColumnDefinition.logicalColumnDepth)
outcome = 'red';
else
outcome = 'blue';

outcomes.push(outcome);
}
}
}
}
});
});

return outcomes;
}
Expand Down