Multi-currency display: FX port + per-user display currency - #13
Merged
Conversation
Roadmap item ("Multi-currency valuations — FX port + display currency
preference; cents-per-point stays USD-denominated internally").
- domain: FxRateSource port + supported display currencies (USD/EUR/GBP/CAD/
AUD/JPY) + convertUsdCents (2dp; 0dp JPY) + InvalidDisplayCurrencyError;
UserSettings entity + repository port (one row per user, extended
column-by-column as preferences accrue).
- db: user_setting table + migration 0007 (additive only) + Drizzle repo
(validates currency on read so a bad row degrades loudly).
- infra adapters: HttpFxRateSource (frankfurter-style GET /latest?base=USD,
injectable fetch, 1h in-process cache) + StaticFxRateSource pinned dev rates.
- application: GetUserSettings (defaults USD) / SetDisplayCurrency /
BuildDisplayValue — conversion is best-effort: FX failure or USD returns
null and never breaks the response.
- web: GET/PUT /api/v1/settings; summary response gains an optional `display`
{currency, amount, ratePerUsd}; FX_API_URL env (static fallback otherwise).
- contracts + OpenAPI + api-client (getUserSettings/updateUserSettings) +
docs (api.md) + .env-example.
Verification: 141 tests pass (110 core incl. 7 new + 20 bot + 11 extension);
typecheck + lint clean; migration generated offline (additive).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roadmap item: "Multi-currency valuations — FX port + display currency preference; cents-per-point stays USD-denominated internally." Users pick a display currency; the portfolio summary carries a converted total. No stored data changes with the exchange rate — conversion happens only at the display edge.
FxRateSourceport, supported currencies (USD/EUR/GBP/CAD/AUD/JPY), pureconvertUsdCents(2dp; 0dp for JPY),InvalidDisplayCurrencyError;UserSettingsentity + repository port (one row per user, designed to grow column-by-column — notification prefs are the natural next tenant).user_settingtable + migration0007(additive only) + Drizzle repo (validates the currency on read so a bad row degrades loudly, not silently).HttpFxRateSource(frankfurter-styleGET /latest?base=USD&symbols=…, injectable fetch, 1-hour in-process cache) andStaticFxRateSource(pinned dev rates).GetUserSettings(defaults USD) /SetDisplayCurrency/BuildDisplayValue. Conversion is best-effort: USD or an FX outage yieldsnull, never a broken summary.GET/PUT /api/v1/settings; the summary response gains an optionaldisplay: { currency, amount, ratePerUsd };FX_API_URLenv (static fallback when unset).Verification
Adds migration
0007(new table only, additive). Applies on deploy via the workermigratetask once deploys are enabled (AWS_DEPLOY_ROLE_ARN).🤖 Generated with Claude Code