Repository navigation
Ruff cleanup: 12 errors → 0 (the facts/sitemap scripts) - #92
Merged
Merged
Conversation
Every error was in scripts/build_site_facts.py, scripts/check_site_facts.py or scripts/build_sitemap.py: os.path.join/abspath/getsize/exists (PTH118/ 100/202/110) and one lambda assignment (E731). Converted to the pathlib idioms the rest of the repo already uses, with the repo's pinned ruff 0.15.22 (same as lint.yml): ruff check . -> All checks passed (was 12 errors) ruff format --check -> 167 files already formatted (unchanged) Behavior proven, not assumed: build_site_facts.py regenerates assets/site_facts.json byte-identically, build_sitemap.py regenerates sitemap.xml with no diff, check_site_facts.py passes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not present after the first check poll, so that automated-review signal was skipped. No applicable approval policy or remaining configured signal requires human review.
Sent by Cursor Approval Agent: Pull Request Router and Approver
jcdavis131
pushed a commit
that referenced
this pull request
Oct 18, 2026
Fixes the stale-token CI failures on this branch; ruff errors resolved via master's #92 cleanup.
jcdavis131
pushed a commit
that referenced
this pull request
Oct 18, 2026
…cohesion-redesign Conflict resolutions: - assets/insights.json: #95's kicker taxonomy kept on 17 cards; payroll-per-win card takes master's reviewed 4-season rebuild (title/lede/rows/viz/foot) - assets/insights.js: keep #95's card numbering (NUM_BY_SLUG) + #94's seasons viz renderer; KICKER_THEMES unioned to cover both taxonomies - insights.html/index.html: token-only conflicts, re-stamped All repo gates pass: stamp_assets, sync_public, ruff, site facts, a11y, contrast.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-existing Ruff red, cleared. All 12 errors lived in three scripts — fittingly, two of them are the site-facts gate itself: os.path.* idioms (PTH118/100/202/110) and one lambda assignment (E731) in build_site_facts.py, check_site_facts.py, build_sitemap.py.
Converted to pathlib with the repo's pinned ruff 0.15.22 (same version lint.yml installs): ruff check → all checks passed; ruff format --check → clean.
Behavior verified: site_facts.json regenerates byte-identically, sitemap.xml with no diff, facts gate green. No other files touched.