Repository navigation
Atlas search: recency-ranked suggestions (the Curry wart) - #91
Merged
Merged
Conversation
The suggestion sort only ordered identical names and left everything else in index order — and the index is chronological, so a surname query filled all 8 slots with the oldest namesakes: 'Curry' showed Dell and Michael Curry seasons and never Stephen. Now: match tier (name/word-start before substring), then most recent season first, then name. Verified in a browser: 'Curry' now leads with Stephen Curry 2025-26; 'Dell' and 'Jordan' behave consistently; no page errors.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not present after the first checks poll, so that signal was skipped, and no other configured review signal or approval policy required human review. No reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
jcdavis131
pushed a commit
that referenced
this pull request
Oct 18, 2026
…cohesion-redesign Conflict resolutions: - assets/insights.json: #95's kicker taxonomy kept on 17 cards; payroll-per-win card takes master's reviewed 4-season rebuild (title/lede/rows/viz/foot) - assets/insights.js: keep #95's card numbering (NUM_BY_SLUG) + #94's seasons viz renderer; KICKER_THEMES unioned to cover both taxonomies - insights.html/index.html: token-only conflicts, re-stamped All repo gates pass: stamp_assets, sync_public, ruff, site facts, a11y, contrast.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the known atlas search wart: suggestions were capped at 8 in chronological file order, so 'Curry' surfaced only Dell/Michael Curry seasons and Stephen required typing his full name.
The old comparator only ordered identical names; everything else kept file order. Ranking is now: match tier (name-start/word-start before substring), then most recent season first, then name.
Browser-verified against a local serve: 'Curry' → Stephen Curry 2025–26 first (Seth interleaved by recency, as a surname search should); 'Dell' → Dellavedova's recent seasons, Dell Curry one more letter away; no page errors.