Repository navigation
Tie the promote-manifest escape to an f32 lineage sidecar - #102
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jcdavis131
changed the base branch from
cursor/served-model-check-gaps-abf1
to
master
October 19, 2026 03:05
Export cannot restamp promoted/CURRENT.json or the promote manifest: test_the_export_stage_writes_nothing_under_pipeline_data requires export_assets to write nothing under pipeline/data. After writing the served f32, export now writes assets/mtnn_embeddings.lineage.json (embedding_f32_sha256, promote manifest path + sha256, npz sha256). matching_promote_manifest and check_served_model verify the served f32 against that sidecar and the sidecar's promote-manifest sha against CURRENT.json. files.embedding.sha256 stays the npz. A real promote-then-export passes with no hand restamp; a mismatched f32 fails; a sidecar pointing at a stale CURRENT fails. July v5 is unchanged (no sidecar required; still pinned to INCUMBENT_F32_SHA256). Co-authored-by: Cam Davis <jcdavis131@gmail.com>
cursor
Bot
force-pushed
the
cursor/promote-manifest-f32-tie-abf1
branch
from
October 19, 2026 03:16
b843ed9 to
4dc92b7
Compare
cursor
Bot
changed the title
jcdavis131
marked this pull request as ready for review
October 19, 2026 03:29
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not present on this PR after the first check poll, no applicable approval policies required human review, and this automation had no prior approval to re-evaluate. No reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on current
master(474dc067, #100 and #101 merged). Head:4dc92b7b5348caee6c1955c446879b58df165358. Served model stays July v5 (july-v5-a4918f09); nothing is promoted.Finding
record_exported_f32restampedpromoted/CURRENT.jsonandpromoted/<run>/manifest.jsonunderpipeline/data. That failedtests/test_e2e_smoke.py::test_the_export_stage_writes_nothing_under_pipeline_dataon offline-build (job). Promote still cannot know the f32 sha (files.embedding.sha256is the npz).Fix
Export writes
assets/mtnn_embeddings.lineage.jsonnext to the f32 (not underpipeline/data):embedding_f32_sha256promote_manifest_sha256embedding_npz_sha256check_served_model/matching_promote_manifestverify the served f32 against that sidecar and the sidecar's promote-manifest sha againstCURRENT.json.record_exported_f32is gone.July v5 has no sidecar and stays pinned to
INCUMBENT_F32_SHA256.Tests
test_a_forced_lineage_passes_after_real_promote_then_export,test_export_writes_the_f32_meta_and_lineage_from_the_promoted_bundle(also hashespipeline/databefore/after export).test_a_forced_lineage_fails_when_sidecar_f32_sha_differs.test_a_sidecar_pointing_at_a_stale_promote_manifest_fails.test_the_export_stage_writes_nothing_under_pipeline_datais unchanged and still required.Checks
All green on
4dc92b7b:Do not merge; leaving this for Cam.