Skip to content

Add Add-OpenADGroupMember and Remove-OpenADGroupMember - #97

Merged
jborean93 merged 13 commits into
jborean93:mainfrom
poshAJ:dev
May 7, 2026
Merged

Add Add-OpenADGroupMember and Remove-OpenADGroupMember#97
jborean93 merged 13 commits into
jborean93:mainfrom
poshAJ:dev

Conversation

@poshAJ

@poshAJ poshAJ commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Adds the cmdlets Add-OpenADGroupMember and Remove-OpenADGroupMember
which can be used to add and remove group members respectively.

closes #92

@poshAJ

poshAJ commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

I could not get the tests to run locally to save my life, did run into actions/runner-images#13303 during troubleshooting. I'm on bazzite-dx in a DevContainer (.net10) and DistroShelf, so it's a me issue.

@jborean93 jborean93 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I just have a few minor questions on the replace logic.

Comment thread src/PSOpenAD.Module/Commands/SetOpenADGroupMember.cs Outdated
Comment thread src/PSOpenAD.Module/Commands/SetOpenADGroupMember.cs Outdated
@jborean93

Copy link
Copy Markdown
Owner

I could not get the tests to run locally to save my life, did run into actions/runner-images#13303 during troubleshooting.

That's solved by removing the " in the unit test args for the collector that I need to fix up. I've just done a lot of work in jborean93/PowerShell-OpenAuthenticode#34 that I need to apply here as well which solved a lot of the issues around coverage and coverlet.

@jborean93 jborean93 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great, when testing locally things work as expected. Only have 1 comment left around skipping the LDAP search if we already know the DN.

I do need to do some work to fix up CI though and hopefully I can get that done by the end of the week and then merge this in when those changes are in there. I don't think it will touch any of the changes here so should be easy to rebase once done.

Comment thread src/PSOpenAD.Module/Commands/SetOpenADGroupMember.cs Outdated
@jborean93

Copy link
Copy Markdown
Owner

Test test and build process has been updated in #99. Hopefully that means that CI should now run correctly when you rebase those changes onto your branch.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.31818% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (87581c4) to head (b77863e).

Files with missing lines Patch % Lines
...c/PSOpenAD.Module/Commands/SetOpenADGroupMember.cs 97.61% 0 Missing and 2 partials ⚠️
src/PSOpenAD/ADIdentity.cs 0.00% 1 Missing and 1 partial ⚠️
src/PSOpenAD/LDAP/Control.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   74.41%   80.20%   +5.78%     
==========================================
  Files          62       63       +1     
  Lines        6984     7536     +552     
  Branches      890      902      +12     
==========================================
+ Hits         5197     6044     +847     
+ Misses       1605     1295     -310     
- Partials      182      197      +15     
Flag Coverage Δ
Linux_74_MIT 79.93% <94.31%> (+5.70%) ⬆️
Linux_75_MIT 79.93% <94.31%> (+5.70%) ⬆️
Linux_76_Heimdal 80.02% <94.31%> (+5.68%) ⬆️
Linux_76_MIT 79.93% <94.31%> (+5.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poshAJ
poshAJ requested a review from jborean93 May 7, 2026 01:34
@jborean93

Copy link
Copy Markdown
Owner

Looking great, thank you very much for working on this!

@jborean93
jborean93 merged commit e6f4cdb into jborean93:main May 7, 2026
8 checks passed
@poshAJ
poshAJ deleted the dev branch May 7, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add-OpenADGroupMember and Remove-OpenADGroupMember

2 participants