Add Add-OpenADGroupMember and Remove-OpenADGroupMember - #97
Conversation
|
I could not get the tests to run locally to save my life, did run into actions/runner-images#13303 during troubleshooting. I'm on bazzite-dx in a DevContainer (.net10) and DistroShelf, so it's a me issue. |
jborean93
left a comment
There was a problem hiding this comment.
The changes look good to me, I just have a few minor questions on the replace logic.
That's solved by removing the |
jborean93
left a comment
There was a problem hiding this comment.
The changes look great, when testing locally things work as expected. Only have 1 comment left around skipping the LDAP search if we already know the DN.
I do need to do some work to fix up CI though and hopefully I can get that done by the end of the week and then merge this in when those changes are in there. I don't think it will touch any of the changes here so should be easy to rebase once done.
|
Test test and build process has been updated in #99. Hopefully that means that CI should now run correctly when you rebase those changes onto your branch. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 74.41% 80.20% +5.78%
==========================================
Files 62 63 +1
Lines 6984 7536 +552
Branches 890 902 +12
==========================================
+ Hits 5197 6044 +847
+ Misses 1605 1295 -310
- Partials 182 197 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looking great, thank you very much for working on this! |
Adds the cmdlets Add-OpenADGroupMember and Remove-OpenADGroupMember
which can be used to add and remove group members respectively.
closes #92