Fix Get-OpenADGroupMember with empty group - #100
Merged
Conversation
This change makes sure that `Get-OpenADGroupMember` does not write an error if the group has no members. Instead it will output no items as there are no members. The cmdlet will still error if the `-Identity` points to a group that does not exist.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 74.67% 80.21% +5.54%
==========================================
Files 63 63
Lines 7060 7547 +487
Branches 902 903 +1
==========================================
+ Hits 5272 6054 +782
+ Misses 1604 1296 -308
- Partials 184 197 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes sure that
Get-OpenADGroupMemberdoes not write an error if the group has no members. Instead it will output no items as there are no members. The cmdlet will still error if the-Identitypoints to a group that does not exist.