Add support for a footer row#1235
Open
jcognard-actinvision wants to merge 1 commit intojbetancur:masterfrom
Open
Add support for a footer row#1235jcognard-actinvision wants to merge 1 commit intojbetancur:masterfrom
jcognard-actinvision wants to merge 1 commit intojbetancur:masterfrom
Conversation
✅ Deploy Preview for react-data-table-component ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
edaae53 to
bde3938
Compare
bde3938 to
9b28456
Compare
Owner
|
@jcognard-actinvision I've been a "little slow" to respond but I will take a look at this for consideration and review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
For one of my projects I need to add a footer row to my table and make it configurable by users to display sums, averages and more.
There’s already someone asking for a footer row support in #1208
What
This PR aims to enable support for a footer row by accepting a
showFooterboolean attribute onDataTablecomponent.The content of the footer cells are defined with the
footerContentfunction on the columns properties, which receives all visible rows as an argument, making possible to calculate sums, for example.Example
I hope the quality of code matches your standards as it’s my first contribution.