feat: exposing col sort state as CSS class#1145
Open
david-ampsec wants to merge 1 commit intojbetancur:masterfrom
Open
feat: exposing col sort state as CSS class#1145david-ampsec wants to merge 1 commit intojbetancur:masterfrom
david-ampsec wants to merge 1 commit intojbetancur:masterfrom
Conversation
✅ Deploy Preview for react-data-table-component ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@jbetancur hey, could you approve that pull request? |
land0r
approved these changes
Dec 22, 2023
land0r
left a comment
land0r
left a comment
There was a problem hiding this comment.
Seems good for me, wondering why this pull request is still "Open"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation does not expose column sort state. The styling is hidden behind styled components. This PR adds an
active_sortclass to columns when using a customsortIcon.