Move stem from preprocessing to nlp#186
Merged
jbesomi merged 2 commits intoSep 14, 2020
Merged
Conversation
Owner
|
Very much agree! Thanks. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We believe the stem function belongs to the NLP module and not the preprocessing module (together with lemmatization that will be implemented in #173 ). Of course it can make sense to use it in preprocessing (and we should explain that in the NLP tutorial in #176 , but in our opinion it's more "Natural Language Processing" than "Preprocessing" so it should be moved.
Of course, no code is changed in this PR, only moved.