Skip to content

Add drop duplicates; closes #4#150

Draft
mk2510 wants to merge 3 commits into
jbesomi:masterfrom
SummerOfCode-NoHate:drop_duplicates
Draft

Add drop duplicates; closes #4#150
mk2510 wants to merge 3 commits into
jbesomi:masterfrom
SummerOfCode-NoHate:drop_duplicates

Conversation

@mk2510
Copy link
Copy Markdown
Collaborator

@mk2510 mk2510 commented Aug 11, 2020

closes #4

added the drop duplicates function to the representation module 🤖 and created unit test :octocat:

mk2510 and others added 3 commits August 10, 2020 22:04
@mk2510 @henrifroese
drop duplicates implemented
0b8a828 
missing: test and comments



Co-authored-by: Henri Froese <hf2000510@gmail.com>
@mk2510
added comments
a47bef5 
missing: tests
@mk2510
added unit tests
2af6888
@mk2510 mk2510 marked this pull request as draft August 12, 2020 15:36
@henrifroese
Copy link
Copy Markdown
Collaborator

henrifroese commented Aug 13, 2020

Put on hold until Series Types are figured out.

@henrifroese henrifroese changed the title Added function drop duplicates Add drop duplicates; closes #4 Aug 13, 2020
@henrifroese
Copy link
Copy Markdown
Collaborator

henrifroese commented Aug 19, 2020

  • Prepare tutorial for different options (pairwise distances, clustering, hashing, approximation algo) to drop duplicates and maybe not implement it in texthero

@henrifroese henrifroese added the enhancement New feature or request label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add drop_duplicates

2 participants

@mk2510 @henrifroese