Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the proposal draft for std::protocol / std::protocol_view to improve clarity, tighten motivation, and expand the design/technical discussion around reflection and code injection.
Changes:
- Rewrites the Abstract and Motivation for a more direct description of structural subtyping and the owning vs non-owning types.
- Restructures “Design requirements” into a “Design” section with explicit requirements and design decisions.
- Expands “Impact on the Standard” / “Technical Specifications” to distinguish what’s feasible with C++26 reflection vs what needs post-C++26 injection support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+197
to
+198
| We anticipate that a complete implementation will be possible once member | ||
| function injection, as discussed in P3996 and related papers, is standardised. |
There was a problem hiding this comment.
This mentions "P3996" but there is no corresponding entry in the References section. Please add a reference (with link) or update the paper number to the correct one so readers can locate the cited proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.