Repository navigation
Probe: Windows state-write stall (do not merge) - #22
Closed
maxrossignol wants to merge 1 commit into
Closed
maxrossignol wants to merge 1 commit into
maxrossignol wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Findings: 30 isolated runs and 10 full unit-suite runs on windows-latest all passed; 150 writes took 1.1–4.2 s, no write phase (open, write, sync_all, rename, ACL) ever exceeded 250 ms, and Defender real-time protection is off on the runners. With one lock order on every write path (state_write first) and no writer panic, the 60 s timeout on main (run 39420674701) was a stall of that runner (its build was also ~50% slower than usual), not a code defect. Closing unmerged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway diagnosis for main's Windows failure after #21:
server::tests::concurrent_state_writes_all_succeed_and_the_last_one_is_currenttimed out after 60 s (run 39420674701), where the whole unit binary normally takes 3 to 16 s on Windows.This branch times each phase of
write_private_atomic(open, write,sync_all, rename, ACL) and each writer's round, prints Defender's state, then runs the test alone 30 times and the full unit suite 10 times onwindows-latestonly. It is closed unmerged once the cause is known.🤖 Generated with Claude Code