Repository navigation
fix(bridge): bound the append-drop policy and finalize dropped terminal events (warren-fb5e) - #1261
Merged
Merged
Conversation
…al events (warren-fb5e) Review follow-up on the run_61kgmmjr94p3 PR: a swallowed append failure now goes through appendOrDrop, which rethrows after three consecutive failures so a store outage still reaches the reconnect path, and a dropped terminal event still sets terminalDetected so reap finalizes. (cherry picked from commit 018e5f0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1260, which merged before this review commit landed on its branch.
events.appendfailure now goes throughappendOrDrop(src/runs/stream/append-guard.ts), which rethrows after three consecutive failures so a store outage still reaches the reconnect path instead of silently dropping the whole stream witherrored=false.terminalDetectedso reap finalizes the run instead of leaving itrunningforever.bridge.tsunder the 500-line budget.Tests: append-guard unit suite plus two bridge tests (three-strike rethrow, dropped terminal). Refs warren-fb5e.