Repository navigation
run detail Runtime + Spend facts: base commit is blank because runs.bas… - #1224
Merged
Merged
Conversation
Add runs.base_sha (sqlite + postgres drizzle schemas, generated migration pair) — the resolved workspace base SHA, measured at reap where commits_ahead is measured: outcome-facts now reads git merge-base of the diff base and the workspace HEAD alongside the numstat pass (single fetch under the K8s clone path), stamped through RunOutcomeFacts / RunsRepo.setOutcomeFacts. Classified public in PUBLIC_RUN_FIELDS, added to the SDK + UI RunRow types, and rendered in the run-detail Runtime panel with the dispatch-time base_commit pin as a labelled 'base pin' fallback. Apply the maxCostUsd dispatch-context overlay in getRunHandler too — today only the runs list did it — so the Spend panel can render '$X of $Y cap' (plus the mobile % OF CAP arm when both cost and cap exist). Operator-only, same posture as the list overlay; the run-detail golden envelope and the projection tests pin the new detail shape. UI tests, the reap run-row facts test, and the fakeExec helper all updated for the fifth measured fact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy sweep for pages no other child opens: instance.tsx:180 ('Server id… (#1219)
Run
run_4yfhqbtark5nSeeds
Commits (4)
Files changed
Prompt
Show prompt
🤖 Opened by warren run
run_4yfhqbtark5n