[jaylfc]

CARD TITLE (intent, not commit subject): session-mode: availability must require the FALLBACK unit (plasma-mobile.service) as well as taos-kiosk.service, so a desk with no fallback is never offered a switch

Autonomous build of board card tsk-mtf4dv.

Session mode availability must require both units

Docs-Reviewed: behavior change limited to device gate logic, no API contract change requiring doc updates

FAILED tests/test_session_mode.py::test_state_unavailable_on_desk_without_fallback - assert True is False
FAILED tests/test_session_mode.py::test_switch_refused_on_desk_without_fallback - AttributeError: 'dict' object has no attribute 'status_code'
2 failed, 4 passed in 0.29s

All tests pass after fix.

Files:
.../tsk-mtf4dv-session-mode-needs-fallback.md | 1 +
tests/test_session_mode.py | 48 ++++++++++++++++++++++
tinyagentos/routes/system.py | 6 ++-
3 files changed, 53 insertions(+), 2 deletions(-)

In-house review (pre-PR)

in-house-review: PASS (kilo/nvidia/nemotron-3-ultra-550b-a55b:free)

reviewer output

VERDICT: PASS

• NIT: changelog.d/tsk-mtf4dv-session-mode-needs-fallback.md:1 literal \n in diff output (likely a display artifact; file should have actual newline)

In-house-Review: PASS model=kilo/nvidia/nemotron-3-ultra-550b-a55b:free head=ef9471546 needs-lead=0

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: jaylfc/taOS
• Branch: exec/tsk-mtf4dv
• File: .coderabbit.yaml
• Commit: ef94715
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 71895c70-d807-4d39-bbc3-f8116152af1a

Commits

Reviewing files that changed from the base of the PR and between 39304e3 and ef94715.

Files selected for processing: 3

• changelog.d/tsk-mtf4dv-session-mode-needs-fallback.md
• tests/test_session_mode.py
• tinyagentos/routes/system.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[jaylfc]

Lead: closing as superseded by #3967 (tsk-l6jtud), which makes the same _session_mode_state change (kiosk AND plasma units) with its own red-first tests and already has a lead PASS. The lane built this card exactly as written. The duplicate was the lead's carding error, not the lane's. The 404 message reword is a deferrable nit. (Also: the changelog fragment here has a literal \n instead of a newline.)