Skip to content

PL-124: a typed value is never hidden, the open-click aims at the row, an update must change something - #105

Merged
jayanthvee merged 2 commits into
mainfrom
pl-124
Oct 28, 2026
Merged

jayanthvee merged 2 commits into
mainfrom
pl-124

Conversation

@jayanthvee

Copy link
Copy Markdown
Owner

Fixes the owner's first price run after PL-123 (ticket: internal/agent/tickets/PL-124.md, evidence beside it).

What was wrong

  • At Stop the cleaning model hid the typed Sales Price (3200) and kept Odoo's own value (400). It couldn't tell them apart: the page/person flag never reached it, and nothing stopped it hiding a typed value.
  • The panel listed Odoo's own values as typed steps.
  • The open-click was saved as the literal "On hand: 18.00".
  • With no price step, the update key was the product alone, so Oak and Mesh were skipped as "already committed in an earlier run".
  • A blank work window was reported as "not found".

What changed

  1. hiddenSeqs (make-recipe.ts): the page's own fills and selects are hidden by their flag; a value the person typed is never hidden; the model may hide only clicks and presses. The clean route sends by: page|person per step and no values; the prompt explains it.
  2. Compiler: the first click after a search that opens a record is aimed at {{row.<search column>}} outside the search box, with the intent "open the result found by ...".
  3. Compiler: an update that writes nothing is refused ("This task doesn't change anything...").
  4. Batch check: each mapping entry says whether a step, key or rule reads it; Try one row lists only those.
  5. Command session: a target not found re-asks ensureDrawing; a page that still draws nothing gets the drawing sentence.

Not done: the screenshot from item 5 (there's no screenshot path to the runner yet).

Gates

pytest 1489 passed and 7 skipped, ruff clean, extension check, web 381 tests and build.

…e row, an update must change something

The page's own values are hidden by their flag and a value the person typed is never hidden; the cleaning model may hide only clicks and presses and now learns who made each step. The click that opens a searched result targets the row's value. An update that writes nothing is refused. Try one row lists only columns a step reads. A target not found on a page that stopped drawing reports the drawing sentence.
@jayanthvee
jayanthvee merged commit 49a76d9 into main Oct 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant