Case Sensitive Headers Matching#193
Open
anikoloutsos wants to merge 1 commit into
Open
Conversation
- Added case-insensitive check to getResponseHeadersStartingWith method - Added validation for null prefix
pdowler
reviewed
Jan 17, 2023
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
I had a fix fo this in PR #188 but since I didn't add test code this is perferrable.
Once minor improvement: the prefix.toLowerCase() on line 42 can be done once outside the for loop (yeah, optimizer and/or string interning probably make it not matter, but still...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192